903311 - Remove support for chrome access to history[n].

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Johnny Stenback (:jst)]

From a quick grep in the source tree it seems like there's only a handful of users of window.history[n] in our tree, and per bz's bug 859707 comment 8 the existence of the chrome only history[n] getter is detectable by web content. It's not part of the web platform, we should remove it in favor of an explicit chrome only method whose existence is not detectable by web content.

Comment 1

[Johnny Stenback (:jst)]

Actually, I can't find a single usage of history[n] in our whole repo. Nor can I find one in the AMO mxr. Also, seems history.current, history.previous, and history.next are also completely unused in our repo.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Seems fairly plausible; http://people.mozilla.org/~choller/firefox/coverage/mc-coverage-20130210-29dd80c95b7d/dom/base/nsDOMClassInfo.cpp.gcov.html and http://people.mozilla.org/~choller/firefox/coverage/mc-coverage-20130210-29dd80c95b7d/dom/base/nsHistory.cpp.gcov.html report no hits

Comment 3

[Boris Zbarsky [:bzbarsky]]

Johnny, do you plan to do this, or does it need another owner?

Comment 4

[Johnny Stenback (:jst)]

Attachment: Remove all chrome only methods from History.

This is green on try, surprisingly.

Comment 5

[Johnny Stenback (:jst)]

Oh, and the attached patch applies on top of the patch in bug 859707.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 788486 [details] [diff] [review]
Remove all chrome only methods from History.

Good deal!

Comment 7

[Johnny Stenback (:jst)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8fbc8f215653

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/8fbc8f215653

\o/

Comment 9

[Kohei Yoshino [:kohei]]

Updated: https://developer.mozilla.org/en-US/docs/Web/API/window.history

Comment 10

[Jorge Villalobos [:jorgev] (he/him)]

I see some instances of this in the Add-ons MXR, mostly from libraries.

Comment 11

[Johnny Stenback (:jst)]

(In reply to Jorge Villalobos [:jorgev] from comment #10)
> I see some instances of this in the Add-ons MXR, mostly from libraries.

Hmm, can you share some examples? I thought I looked, and got nothing, but it was quite a while ago...

Thanks.

Comment 12

[Jorge Villalobos [:jorgev] (he/him)]

Searching for window.history shows several results: https://mxr.mozilla.org/addons/search?string=window.history

For example:
https://mxr.mozilla.org/addons/source/8062/chrome/content/ode/js/main.js#840